Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/10502#discussion_r48590599 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala --- @@ -208,11 +210,30 @@ private[sql] object ParquetFilters { } /** + * Return referenced columns in [[sources.Filter]]. + */ + def referencedColumns(schema: StructType, predicate: sources.Filter): Array[String] = { --- End diff -- Oh, yes it looks so. I think I might also have to change `createFilter()` in that way because I just followed up in the way of `createFilter()` for this function because both `createFilter()` and `referencedColumns()` are called in the same places.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org