Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/10502#discussion_r48592707
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
---
@@ -208,11 +210,30 @@ private[sql] object ParquetFilters {
}
/**
+ * Return referenced columns in [[sources.Filter]].
+ */
+ def referencedColumns(schema: StructType, predicate: sources.Filter):
Array[String] = {
+ val dataTypeOf = schema.map(f => f.name -> f.dataType).toMap
+ val referencedColumns = ArrayBuffer.empty[String]
+ def getDataTypeOf(name: String): DataType = {
+ referencedColumns += name
+ dataTypeOf(name)
+ }
+ createParquetFilter(getDataTypeOf, predicate)
--- End diff --
Understood though, I think easy-to-read is better.
This entry is a little hacky and I was not clearly sure what it made.
Anyway, we should follow comitters comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
