Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1056#discussion_r14864526
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -341,4 +345,47 @@ private[spark] class Executor(
}
}
}
+
+ def stop() {
+ isStopped = true
+ threadPool.shutdown()
+ }
+
+ def startDriverHeartbeater() {
+ val interval = conf.getInt("spark.executor.heartbeatInterval", 2000)
+ val timeout = AkkaUtils.lookupTimeout(conf)
+ val retryAttempts = AkkaUtils.numRetries(conf)
+ val retryIntervalMs = AkkaUtils.retryWaitMs(conf)
+ val heartbeatReceiverRef =
AkkaUtils.makeDriverRef("HeartbeatReceiver", conf, env.actorSystem)
+
+ val t = new Thread() {
+ override def run() {
+ Thread.sleep(interval)
+
+ while (!isStopped) {
+ val tasksMetrics = new ArrayBuffer[(Long, TaskMetrics)]()
+ for (taskRunner <- runningTasks.values()) {
+ val task = taskRunner.task
--- End diff --
minor: I wouldn't bother with setting this to a variable, since you only
use it once. Also, you already have a `var` up there called task, so this might
be confusing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
