Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1056#discussion_r14864590
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
    @@ -81,13 +81,16 @@ private[spark] class EventLoggingListener(
     
       /** Log the event as JSON. */
       private def logEvent(event: SparkListenerEvent, flushLogger: Boolean = 
false) {
    -    val eventJson = JsonProtocol.sparkEventToJson(event)
    -    logger.logLine(compact(render(eventJson)))
    -    if (flushLogger) {
    -      logger.flush()
    -    }
    -    if (testing) {
    -      loggedEvents += eventJson
    +    // Don't log metrics updates because there are too many of them
    +    if (!event.isInstanceOf[SparkListenerExecutorMetricsUpdate]) {
    +      val eventJson = JsonProtocol.sparkEventToJson(event)
    +      logger.logLine(compact(render(eventJson)))
    +      if (flushLogger) {
    +        logger.flush()
    +      }
    +      if (testing) {
    +        loggedEvents += eventJson
    +      }
    --- End diff --
    
    You don't need to special case this, since you don't even have a handler 
down there for this event (which is correct)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to