Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r48715166
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -75,6 +76,19 @@ private[sql] object JDBCRelation {
}
ans.toArray
}
+
+ def getEffectiveProperties(
--- End diff --
+1 on Sean's comments. Also, could you add a one- or two-line comment to
explain what's going on here? Maybe give this method Scaladoc?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
