Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r48715260
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -88,7 +101,8 @@ private[sql] case class JDBCRelation(
override val needConversion: Boolean = false
- override val schema: StructType = JDBCRDD.resolveTable(url, table,
properties)
+ override val schema: StructType =
+ JDBCRDD.resolveTable(url, table,
JDBCRelation.getEffectiveProperties(properties))
--- End diff --
The non-serializability doesn't come into play here since this runs
entirely on the driver, right? Or can this method wind up being called on
executors?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
