Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10128#issuecomment-169089482
This seems like a reasonable thing to do, but the implementation seems
unnecessarily complex. Why not just:
- `transform` the condition, matching on non deterministic subtrees with
no references.
- when you find one create an alias and add it to an `ArrayBuffer`,
replacing the tree with `alias.toAttribute`
- if the array buffer is empty, return the same tree. otherwise, add the
two projections as you do now and use the transformed condition for the join.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
