Github user zhonghaihua commented on the pull request:

    https://github.com/apache/spark/pull/10128#issuecomment-169231327
  
    @marmbrus Thanks for your suggestions. I think your idea can simply solve 
problem. But in some situations, this seems not very suitable. 
    For example:
    `Join(testRelation, testRelation2, Inner,Some(And(EqualTo(a, b), 
EqualTo(Rand(33) * c, d))))` If `c` is an attribute belong to `testRelation2`, 
I think `Rand(33)` is more appropriately pulled out to the right child tree of 
`Join`, otherwise, if belong to `testRelation`, it is appropriately pulled out 
to left child tree. 
    
    When `nondeterministic expressions` is used with `table attribute`, I think 
pull out it should depend on the attribute. What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to