Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10569#discussion_r48881260
--- Diff: core/src/main/scala/org/apache/spark/Aggregator.scala ---
@@ -34,10 +34,6 @@ case class Aggregator[K, V, C] (
mergeValue: (C, V) => C,
mergeCombiners: (C, C) => C) {
- @deprecated("use combineValuesByKey with TaskContext argument", "0.9.0")
- def combineValuesByKey(iter: Iterator[_ <: Product2[K, V]]):
Iterator[(K, C)] =
- combineValuesByKey(iter, null)
--- End diff --
Ha, the old code here doesn't even make sense: why not pass
`TaskContext.get()` instead of null? Glad to see this gone.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
