Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10569#discussion_r48881942
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -2364,113 +2258,6 @@ object SparkContext extends Logging {
*/
private[spark] val LEGACY_DRIVER_IDENTIFIER = "<driver>"
- // The following deprecated objects have already been copied to `object
AccumulatorParam` to
- // make the compiler find them automatically. They are duplicate codes
only for backward
- // compatibility, please update `object AccumulatorParam` accordingly if
you plan to modify the
- // following ones.
-
- @deprecated("Replaced by implicit objects in AccumulatorParam. This is
kept here only for " +
- "backward compatibility.", "1.3.0")
- object DoubleAccumulatorParam extends AccumulatorParam[Double] {
- def addInPlace(t1: Double, t2: Double): Double = t1 + t2
- def zero(initialValue: Double): Double = 0.0
- }
-
- @deprecated("Replaced by implicit objects in AccumulatorParam. This is
kept here only for " +
- "backward compatibility.", "1.3.0")
- object IntAccumulatorParam extends AccumulatorParam[Int] {
- def addInPlace(t1: Int, t2: Int): Int = t1 + t2
- def zero(initialValue: Int): Int = 0
- }
-
- @deprecated("Replaced by implicit objects in AccumulatorParam. This is
kept here only for " +
- "backward compatibility.", "1.3.0")
- object LongAccumulatorParam extends AccumulatorParam[Long] {
- def addInPlace(t1: Long, t2: Long): Long = t1 + t2
- def zero(initialValue: Long): Long = 0L
- }
-
- @deprecated("Replaced by implicit objects in AccumulatorParam. This is
kept here only for " +
- "backward compatibility.", "1.3.0")
- object FloatAccumulatorParam extends AccumulatorParam[Float] {
- def addInPlace(t1: Float, t2: Float): Float = t1 + t2
- def zero(initialValue: Float): Float = 0f
- }
-
- // The following deprecated functions have already been moved to `object
RDD` to
- // make the compiler find them automatically. They are still kept here
for backward compatibility
- // and just call the corresponding functions in `object RDD`.
-
- @deprecated("Replaced by implicit functions in the RDD companion object.
This is " +
- "kept here only for backward compatibility.", "1.3.0")
- def rddToPairRDDFunctions[K, V](rdd: RDD[(K, V)])
- (implicit kt: ClassTag[K], vt: ClassTag[V], ord: Ordering[K] =
null): PairRDDFunctions[K, V] =
- RDD.rddToPairRDDFunctions(rdd)
-
- @deprecated("Replaced by implicit functions in the RDD companion object.
This is " +
- "kept here only for backward compatibility.", "1.3.0")
- def rddToAsyncRDDActions[T: ClassTag](rdd: RDD[T]): AsyncRDDActions[T] =
- RDD.rddToAsyncRDDActions(rdd)
-
- @deprecated("Replaced by implicit functions in the RDD companion object.
This is " +
- "kept here only for backward compatibility.", "1.3.0")
- def rddToSequenceFileRDDFunctions[K <% Writable: ClassTag, V <%
Writable: ClassTag](
- rdd: RDD[(K, V)]): SequenceFileRDDFunctions[K, V] = {
- val kf = implicitly[K => Writable]
- val vf = implicitly[V => Writable]
- // Set the Writable class to null and `SequenceFileRDDFunctions` will
use Reflection to get it
- implicit val keyWritableFactory = new WritableFactory[K](_ => null, kf)
- implicit val valueWritableFactory = new WritableFactory[V](_ => null,
vf)
- RDD.rddToSequenceFileRDDFunctions(rdd)
- }
-
- @deprecated("Replaced by implicit functions in the RDD companion object.
This is " +
- "kept here only for backward compatibility.", "1.3.0")
- def rddToOrderedRDDFunctions[K : Ordering : ClassTag, V: ClassTag](
- rdd: RDD[(K, V)]): OrderedRDDFunctions[K, V, (K, V)] =
- RDD.rddToOrderedRDDFunctions(rdd)
-
- @deprecated("Replaced by implicit functions in the RDD companion object.
This is " +
- "kept here only for backward compatibility.", "1.3.0")
- def doubleRDDToDoubleRDDFunctions(rdd: RDD[Double]): DoubleRDDFunctions =
- RDD.doubleRDDToDoubleRDDFunctions(rdd)
-
- @deprecated("Replaced by implicit functions in the RDD companion object.
This is " +
- "kept here only for backward compatibility.", "1.3.0")
- def numericRDDToDoubleRDDFunctions[T](rdd: RDD[T])(implicit num:
Numeric[T]): DoubleRDDFunctions =
- RDD.numericRDDToDoubleRDDFunctions(rdd)
-
- // The following deprecated functions have already been moved to `object
WritableFactory` to
- // make the compiler find them automatically. They are still kept here
for backward compatibility.
-
- @deprecated("Replaced by implicit functions in the WritableFactory
companion object. This is " +
- "kept here only for backward compatibility.", "1.3.0")
- implicit def intToIntWritable(i: Int): IntWritable = new IntWritable(i)
-
- @deprecated("Replaced by implicit functions in the WritableFactory
companion object. This is " +
- "kept here only for backward compatibility.", "1.3.0")
- implicit def longToLongWritable(l: Long): LongWritable = new
LongWritable(l)
-
- @deprecated("Replaced by implicit functions in the WritableFactory
companion object. This is " +
- "kept here only for backward compatibility.", "1.3.0")
- implicit def floatToFloatWritable(f: Float): FloatWritable = new
FloatWritable(f)
-
- @deprecated("Replaced by implicit functions in the WritableFactory
companion object. This is " +
- "kept here only for backward compatibility.", "1.3.0")
- implicit def doubleToDoubleWritable(d: Double): DoubleWritable = new
DoubleWritable(d)
-
- @deprecated("Replaced by implicit functions in the WritableFactory
companion object. This is " +
- "kept here only for backward compatibility.", "1.3.0")
- implicit def boolToBoolWritable (b: Boolean): BooleanWritable = new
BooleanWritable(b)
-
- @deprecated("Replaced by implicit functions in the WritableFactory
companion object. This is " +
- "kept here only for backward compatibility.", "1.3.0")
- implicit def bytesToBytesWritable (aob: Array[Byte]): BytesWritable =
new BytesWritable(aob)
-
- @deprecated("Replaced by implicit functions in the WritableFactory
companion object. This is " +
- "kept here only for backward compatibility.", "1.3.0")
- implicit def stringToText(s: String): Text = new Text(s)
-
private implicit def arrayToArrayWritable[T <% Writable: ClassTag](arr:
Traversable[T])
--- End diff --
Do we still need this? We can always remove in a followup if not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
