Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10541#discussion_r49039209
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -931,6 +931,14 @@ case class Cast(child: Expression, dataType: DataType)
extends UnaryExpression {
$evPrim = $result.copy();
"""
}
+
+ override def sql: Option[String] = {
+ if (foldable) {
+ Literal.create(eval(), dataType).sql
+ } else {
+ child.sql.map(childSQL => s"CAST($childSQL AS ${dataType.sql})")
--- End diff --
How about we do not evaluate the expr if it is foldable? I think it does
not really give us any benefit if we evaluate it at here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
