Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10541#discussion_r49040262
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
 ---
    @@ -226,6 +234,11 @@ case class InSet(child: Expression, hset: Set[Any]) 
extends UnaryExpression with
           }
          """
       }
    +
    +  override def sql: Option[String] = for {
    +    valueSQL <- child.sql
    +    listSQL <- sequenceOption(hset.toSeq.map(Literal(_).sql))
    +  } yield s"($valueSQL IN (${listSQL.mkString(", ")}))"
    --- End diff --
    
    Maybe we do not need to support InSet right now? It is only created by the 
optimizer. Also, values in the set are in our internal type, I am not sure if 
using `toString` works.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to