Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/10150#discussion_r49251288
--- Diff: python/pyspark/mllib/clustering.py ---
@@ -38,13 +38,120 @@
from pyspark.mllib.util import Saveable, Loader, inherit_doc, JavaLoader,
JavaSaveable
from pyspark.streaming import DStream
-__all__ = ['KMeansModel', 'KMeans', 'GaussianMixtureModel',
'GaussianMixture',
- 'PowerIterationClusteringModel', 'PowerIterationClustering',
- 'StreamingKMeans', 'StreamingKMeansModel',
+__all__ = ['BisectingKMeansModel', 'BisectingKMeans', 'KMeansModel',
'KMeans',
+ 'GaussianMixtureModel', 'GaussianMixture',
'PowerIterationClusteringModel',
+ 'PowerIterationClustering', 'StreamingKMeans',
'StreamingKMeansModel',
'LDA', 'LDAModel']
@inherit_doc
+class BisectingKMeansModel(JavaModelWrapper):
+ """
+ .. note:: Experimental
+
+ A clustering model derived from the bisecting k-means method.
+
+ >>> data = array([0.0,0.0, 1.0,1.0, 9.0,8.0, 8.0,9.0]).reshape(4, 2)
+ >>> bskm = BisectingKMeans()
+ >>> model = bskm.train(sc.parallelize(data), k=4)
+ >>> p = array([0.0, 0.0])
+ >>> model.predict(p) == model.predict(p)
--- End diff --
I'd write this as more of an example than a unit test. It's good to
exercise all functionality, but unit test code should go in tests.py. (We have
been inconsistent about this, but it'd be good to improve.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
