GitHub user JoshRosen opened a pull request:
https://github.com/apache/spark/pull/10748
[SPARK-12817] Simplify CacheManager code and remove unused BlockManager
methods
CacheManager directly calls MemoryStore.unrollSafely() and has its own
logic for handling graceful fallback to disk when cached data does not fit in
memory. However, this logic also exists inside of the MemoryStore itself, so
this appears to be unnecessary duplication.
We can remove this duplication and delete a significant amount of
BlockManager code which existed only to support this CacheManager code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JoshRosen/spark block-manager-cleanup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/10748.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10748
----
commit 302eaa52fc98c79661cb2b17d9e95392a98b18f0
Author: Josh Rosen <[email protected]>
Date: 2016-01-14T01:02:29Z
Remove putArray() and duplicated unroll calls.
commit fdad4126cd0691bb70f224b7a55dc93e471dc0b9
Author: Josh Rosen <[email protected]>
Date: 2016-01-14T01:07:02Z
Inline MemoryStore.putArray() at callsite.
commit 5accde7d27cba46bd274b92db62981398b02608c
Author: Josh Rosen <[email protected]>
Date: 2016-01-14T01:08:58Z
Cleanup post-inlining.
commit 80d375a8962cb79a3a6da1f176f82c709e6a493c
Author: Josh Rosen <[email protected]>
Date: 2016-01-14T01:10:31Z
Remove one of the tryToPut() overloads.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
