Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10748#discussion_r49678000
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala ---
    @@ -58,14 +57,6 @@ private[spark] class DiskStore(blockManager: 
BlockManager, diskManager: DiskBloc
         PutResult(bytes.limit(), Right(bytes.duplicate()))
       }
     
    -  override def putArray(
    -      blockId: BlockId,
    -      values: Array[Any],
    -      level: StorageLevel,
    -      returnValues: Boolean): PutResult = {
    -    putIterator(blockId, values.toIterator, level, returnValues)
    --- End diff --
    
    The fact that these `putArray()` methods just turned around and called 
`putIterator()` suggests to me that this isn't a terribly useful method to 
expose.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to