Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1440#discussion_r15001961
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnStats.scala ---
    @@ -344,21 +344,52 @@ private[sql] class StringColumnStats extends 
BasicColumnStats(STRING) {
       }
     
       override def contains(row: Row, ordinal: Int) = {
    -    !(upperBound eq null) && {
    +    (upperBound ne null) && {
    --- End diff --
    
    Nit: Spark style would probably prefer != here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to