Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1440#discussion_r15035454
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala
---
@@ -93,6 +93,10 @@ class HiveCompatibilitySuite extends HiveQueryFileTest
with BeforeAndAfter {
"partitions_json",
// Timezone specific test answers.
+ "timestamp_1",
--- End diff --
A not so clever solution is to cache golden answers of all timezones for
these tests, then select the right version for the current build according to
system timezone. (And hope developers don't build Spark SQL when traveling
across timezones...)
@yhuai any thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
