Github user mateiz commented on the pull request:

    https://github.com/apache/spark/pull/1362#issuecomment-49208638
  
    This looks good to me modulo a few comments! One other thing though, you 
should add a unit test for this functionality. Create a test that would result 
in a very long running time with the old code (e.g. something where you zip 
RDDs together 20-30 times and the original one has some preferred locations), 
and add something around it to time that it runs within, say, 5 seconds.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to