Github user staple commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1362#discussion_r15041028
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala 
---
    @@ -1107,7 +1106,6 @@ class DAGScheduler(
                 case shufDep: ShuffleDependency[_, _, _] =>
                   val mapStage = getShuffleMapStage(shufDep, stage.jobId)
                   if (!mapStage.isAvailable) {
    -                visitedStages += mapStage
    --- End diff --
    
    Thanks Mark.  I can see that stages will be repeatedly added to 
visitedStages.  What I'm not seeing is the consequence of that - how does 
adding stages to visitedStages affect the functionality here if we never, for 
example, check whether a stage belongs to visitedStages.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to