Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10799#discussion_r49961252
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/bucket.scala
---
@@ -57,15 +57,17 @@ private[sql] abstract class BucketedOutputWriterFactory
extends OutputWriterFact
private[sql] object BucketingUtils {
// The file name of bucketed data should have 3 parts:
- // 1. some other information in the head of file name, ends with `-`
- // 2. bucket id part, some numbers
+ // 1. some other information in the head of file name
+ // 2. bucket id part, some numbers, starts with "_"
// 3. optional file extension part, in the tail of file name, starts
with `.`
// An example of bucketed parquet file name with bucket id 3:
- // part-r-00000-2dd664f9-d2c4-4ffe-878f-c6c70c1fb0cb-00003.gz.parquet
- private val bucketedFileName = """.*-(\d+)(?:\..*)?$""".r
--- End diff --
Maybe also add an example that will cause problem if we use `-`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
