Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10799#discussion_r50036088
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/bucket.scala
---
@@ -57,15 +57,21 @@ private[sql] abstract class BucketedOutputWriterFactory
extends OutputWriterFact
private[sql] object BucketingUtils {
// The file name of bucketed data should have 3 parts:
- // 1. some other information in the head of file name, ends with `-`
- // 2. bucket id part, some numbers
+ // 1. some other information in the head of file name
+ // 2. bucket id part, some numbers, starts with "_"
+ // * The other-information part may use `-` as separator and may
have numbers at the end,
+ // e.g. a normal parquet file without bucketing may have name:
+ // part-r-00000-2dd664f9-d2c4-4ffe-878f-431234567891.gz.parquet,
and we will mistakenly
+ // treat `431234567891` as bucket id. So here we pick `_` as
separator.
--- End diff --
oh, nvm, I just wanna make life easier if the bucket id is at the head.
Since we need to support hive anyway, let's just keep it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
