Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/8734#discussion_r50576539
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/tree/DecisionTreeSuite.scala ---
@@ -294,8 +295,12 @@ class DecisionTreeSuite extends SparkFunSuite with
MLlibTestSparkContext {
assert(topNode.impurity !== -1.0)
// set impurity and predict for child nodes
- assert(topNode.leftNode.get.predict.predict === 0.0)
- assert(topNode.rightNode.get.predict.predict === 1.0)
+ if (topNode.leftNode.get.predict.predict === 0.0) {
--- End diff --
I think now that we are ordering by the correct thing, this change is not
necessary. Since we order by proportion falling in outcome class 1, the hard
prediction 0 will always be before hard prediction 1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
