Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10961#discussion_r51232913
  
    --- Diff: 
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
 ---
    @@ -354,6 +435,33 @@ public void reset() {
       /**
        * Sets the value at rowId to `value`.
        */
    +  public abstract void putFloat(int rowId, float value);
    +
    +  /**
    +   * Sets values from [rowId, rowId + count) to value.
    +   */
    +  public abstract void putFloats(int rowId, int count, float value);
    +
    +  /**
    +   * Sets values from [rowId, rowId + count) to [src + srcIndex, src + 
srcIndex + count)
    +   * src should contain `count` doubles written as ieee format.
    +   */
    +  public abstract void putFloats(int rowId, int count, float[] src, int 
srcIndex);
    +
    +  /**
    +   * Sets values from [rowId, rowId + count) to [src[srcIndex], 
src[srcIndex + count])
    +   * The data in src must be ieee formatted floats.
    --- End diff --
    
    How is the endianness?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to