Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/10961#discussion_r51299383
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVectorUtils.java
---
@@ -59,19 +62,44 @@ public static Object
toPrimitiveJavaArray(ColumnVector.Array array) {
private static void appendValue(ColumnVector dst, DataType t, Object o) {
if (o == null) {
- dst.appendNull();
+ if (t instanceof CalendarIntervalType) {
+ dst.appendStruct(true);
+ } else {
+ dst.appendNull();
+ }
} else {
- if (t == DataTypes.ByteType) {
- dst.appendByte(((Byte)o).byteValue());
+ if (t == DataTypes.BooleanType) {
--- End diff --
No of the functions in this file is perf critical. That's largely why I
didn't put them in the ColumnVector class. This needs to be codegened whenever
we need to do row -> columnarbatch conversion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
