Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10959#discussion_r51338133
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/master/MasterSource.scala ---
    @@ -42,6 +42,6 @@ private[spark] class MasterSource(val master: Master) 
extends Source {
     
       // Gauge for waiting application numbers in cluster
       metricRegistry.register(MetricRegistry.name("waitingApps"), new 
Gauge[Int] {
    -    override def getValue: Int = master.waitingApps.size
    +    override def getValue: Int = master.apps.filter(_.state == 
ApplicationState.WAITING).size
    --- End diff --
    
    "waitingApps" suppose to refer to the number of waiting applications in the 
Master, and `apps` includes all the uncompleted applications including 
`waitingApps`. If there's any inconsistent meaning, I think we should find out 
what actual `waitingApps` usage in `Master`, to see if there's any bug in it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to