Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1499#discussion_r15147904
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/SizeTrackingBuffer.scala
---
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.util.collection
+
+import java.util.Arrays
+import java.util.Comparator
+
+import scala.collection.mutable.ArrayBuffer
+
+import org.apache.spark.util.SizeEstimator
+
+/**
+ * Append-only buffer that keeps track of its estimated size in bytes.
+ * We sample with a slow exponential back-off using the SizeEstimator to
amortize the time,
+ * as each call to SizeEstimator can take a sizable amount of time (order
of a few milliseconds).
+ *
+ * The tracking code is copied from SizeTrackingAppendOnlyMap -- we'll
factor that out soon.
+ */
+private[spark] class SizeTrackingBuffer[T <: AnyRef](initialCapacity: Int
= 64)
+ extends SizeTrackingCollection[T]
--- End diff --
This could be replaced with the buffer in #1165 except we also need
destructiveSortedIterator. And to sort stuff in-place, that in turn requires T
to be a subclass of AnyRef (otherwise we'd have to pass the Array[T] to a
different Arrays.sort() method based on its type).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
