Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10914#discussion_r51656963
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2212,9 +2212,9 @@ private[spark] object Utils extends Logging {
* incompatible. In environments where dynamic allocation is turned on
by default,
* the latter should override the former (SPARK-9092).
*/
- def isDynamicAllocationEnabled(conf: SparkConf): Boolean = {
+ def isDynamicAllocationEnabled(conf: SparkConf, isLocal: Boolean):
Boolean = {
--- End diff --
actually it doesn't look very useful to pass in a flag that always decides
the value of the return type. It appears that `SparkContext` is the only place
where we need to read the flag so let's leave it out of this method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
