Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/10914#issuecomment-178893105
@zjffdu the latest changes look more complicated than before. I think it
would be best to achieve the following:
- all checks involving the conf should be in
`Utils.dynamicAllocationEnabled`
- on second thought the `isLocal` check should just be in `SparkContext`;
it doesn't really make sense for it to be everywhere like the way it is
currently in this patch
Ideally we'd have something like:
```
// In SparkContext
val dynamicAllocationEnabled = Utils.dynamicAllocationEnabled(_conf)
val executorAllocationManager =
if (dynamicAllocationEnabled && !isLocal) {
Some(...)
} else {
None
}
```
does that make sense?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
