Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/11113#discussion_r52214846
--- Diff:
examples/src/main/scala/org/apache/spark/examples/streaming/ActorWordCount.scala
---
@@ -63,11 +63,11 @@ class FeederActor extends Actor {
def receive: Receive = {
case SubscribeReceiver(receiverActor: ActorRef) =>
println("received subscribe from %s".format(receiverActor.toString))
- receivers = LinkedList(receiverActor) ++ receivers
+ receiverActor +=: receivers
case UnsubscribeReceiver(receiverActor: ActorRef) =>
println("received unsubscribe from
%s".format(receiverActor.toString))
- receivers = receivers.dropWhile(x => x eq receiverActor)
+ receivers.dropWhile(x => x eq receiverActor)
--- End diff --
Unfortunately, this does actually not remove the elements from the original
receivers (instead it creates a new ArrayBuffer without the given elements).
Please look at my previous comment, maybe a Set is better suited here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
