Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11113#discussion_r52219962
--- Diff:
examples/src/main/scala/org/apache/spark/examples/streaming/ActorWordCount.scala
---
@@ -63,11 +63,11 @@ class FeederActor extends Actor {
def receive: Receive = {
case SubscribeReceiver(receiverActor: ActorRef) =>
println("received subscribe from %s".format(receiverActor.toString))
- receivers = LinkedList(receiverActor) ++ receivers
+ receiverActor +=: receivers
case UnsubscribeReceiver(receiverActor: ActorRef) =>
println("received unsubscribe from
%s".format(receiverActor.toString))
- receivers = receivers.dropWhile(x => x eq receiverActor)
+ receivers.dropWhile(x => x eq receiverActor)
--- End diff --
Ah, darn you are right there. Is there any mutation method that does this?
Yes you're right that `ListBuffer` or a mutable `Set` could be a better
choice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
