Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/1507#discussion_r15238942
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockFetcherIterator.scala ---
@@ -131,7 +122,9 @@ object BlockFetcherIterator {
val networkSize = blockMessage.getData.limit()
results.put(new FetchResult(blockId, sizeMap(blockId),
() => dataDeserialize(blockId, blockMessage.getData,
serializer)))
- _remoteBytesRead += networkSize
+ // TODO: race conditions can occur here with
NettyBlockFetcherIterator
--- End diff --
Might be good to file a JIRA for metrics for the NettyBlockFetcherIterator
more generally -- I noticed yesterday that the Netty version also doesn't
report fetchWaitTime
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
