Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/1507#discussion_r15246688
--- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala
---
@@ -75,9 +76,12 @@ class TaskMetrics extends Serializable {
/**
* If this task reads from shuffle output, metrics on getting shuffle
data will be collected here
*/
- private var _shuffleReadMetrics: Option[ShuffleReadMetrics] = None
+ var shuffleReadMetrics: Option[ShuffleReadMetrics] = None
--- End diff --
I agree it would be a little clearer, but I'm worried that it's too verbose
and is going to make a bunch of lines spill over 100 characters. It's mainly
read in the driver, which doesn't really care that it's aggregated.
Would a comment be sufficient?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
