Github user dragos commented on a diff in the pull request:
https://github.com/apache/spark/pull/11292#discussion_r53619838
--- Diff:
core/src/main/java/org/apache/spark/shuffle/sort/ShuffleInMemorySorter.java ---
@@ -30,7 +30,9 @@
private static final class SortComparator implements
Comparator<PackedRecordPointer> {
@Override
public int compare(PackedRecordPointer left, PackedRecordPointer
right) {
- return left.getPartitionId() - right.getPartitionId();
+ int leftId = left.getPartitionId();
+ int rightId = right.getPartitionId();
+ return leftId < rightId ? -1 : (leftId > rightId ? 1 : 0);
--- End diff --
What's the rationale? I don't think this makes the code more readable. If
you want to return just one of `-1, 0, 1` you could use `Integer.signum`,
though it's not necessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
