Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11292#discussion_r53621494
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -850,7 +850,7 @@ public int compareTo(@Nonnull final UTF8String other) {
return res;
}
}
- return numBytes - other.numBytes;
+ return numBytes < other.numBytes ? -1 : (numBytes > other.numBytes ? 1
: 0);
--- End diff --
Oops, this is not something to change, since `numBytes` is nonnegative.
Overflow in the subtraction is the usual reason for this fix, not readability.
But this can't overflow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
