Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10705#discussion_r53708381
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -521,16 +509,17 @@ private[spark] class BlockManager(
}
}
}
+ } else {
+ releaseLock(blockId)
+ None
}
- }
- } else {
- logDebug(s"Block $blockId not registered locally")
}
- None
}
/**
* Get block from remote block managers.
+ *
+ * This does not acquire a local lock on this block.
--- End diff --
I think "This does not acquire a lock on this block in this JVM" is
clearer. The concept of "local lock" is not super intuitive (is there a "remote
lock"?)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
