Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10705#discussion_r53719828
--- Diff: core/src/main/scala/org/apache/spark/CacheManager.scala ---
@@ -136,7 +147,13 @@ private[spark] class CacheManager(blockManager:
BlockManager) extends Logging {
*/
blockManager.putIterator(key, values, level, tellMaster = true,
effectiveStorageLevel)
blockManager.get(key) match {
- case Some(v) => v.data.asInstanceOf[Iterator[T]]
+ case Some(v) =>
+ val iter = v.data.asInstanceOf[Iterator[T]]
+ if (v.readMethod != DataReadMethod.Network) {
+ CompletionIterator[T, Iterator[T]](iter,
blockManager.releaseLock(key))
--- End diff --
Then actually here we don't need to do the network check, since here we're
getting the block that we literally just put in. E.g. the effective storage
level here is `DISK_ONLY`, so we just read it from our local disk, in which
case we *always* have to release the lock.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
