GitHub user marmbrus opened a pull request:
https://github.com/apache/spark/pull/11316
[SPARK-13440][SQL] ObjectType should accept any ObjectType
The type checking functions of `If` and `UnwrapOption` are fixed to
eliminate spurious failures. `UnwrapOption` was checking for an input of
`ObjectType` but `ObjectType`'s accept function was hard coded to return
`false`. `If` was failing to returning a false positive in the case that the
two options differed only by nullability.
Tests added:
- an end-to-end regression test is added to `DatasetSuite` for the
reported failure.
- all the unit tests in `ExpressionEncoderSuite` are augmented to also
confirm successful analysis. These tests are actually what pointed out the
additional issues with `If` resolution.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/marmbrus/spark datasetOptions
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/11316.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11316
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
