Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11316#discussion_r53736140
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/types/ObjectType.scala ---
    @@ -23,8 +23,10 @@ private[sql] object ObjectType extends AbstractDataType {
       override private[sql] def defaultConcreteType: DataType =
         throw new UnsupportedOperationException("null literals can't be casted 
to ObjectType")
     
    -  // No casting or comparison is supported.
    -  override private[sql] def acceptsType(other: DataType): Boolean = false
    +  override private[sql] def acceptsType(other: DataType): Boolean = other 
match {
    +    case ObjectType(_) => true
    --- End diff --
    
    should we also compare the `Class[_]`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to