Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/10705#issuecomment-187489387
OK I just went through a round of close review. I manually checked all the
places where you acquired and released locks and confirmed that they were
correct. However, it was a very time consuming process and I imagine it will be
a pain in the future if someone else wants to make changes. At the same time
this problem is inherently complex so I'm not sure if there's a more reasonable
way to do this.
I believe the few main things left to address are:
- wrap more things in try finally to make sure we still release locks if
things go wrong
- make it harder for future developers to forget about releasing locks
(which is pretty easy today)
- clean up some duplicate code
Overall the patch is very solid; I could not find glaring correctness
issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
