Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10705#discussion_r53724680
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -597,6 +586,9 @@ private[spark] class BlockManager(
/**
* Get a block from the block manager (either local or remote).
+ *
+ * This acquires a read lock on the block if the block was stored
locally and does not acquire
+ * any locks if the block was fetched from a remote block manager.
--- End diff --
we should expand on this comment that the caller may check whether the
`readMethod` of the `BlockResult` is network, and if so, do not release the
lock (i.e. what we do in `CacheManager`)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
