Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11319#discussion_r53762980
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -110,7 +110,7 @@ object QuantileDiscretizer extends
DefaultParamsReadable[QuantileDiscretizer] wi
val totalSamples = dataset.count()
require(totalSamples > 0,
"QuantileDiscretizer requires non-empty input dataset but was given
an empty input.")
- val requiredSamples = math.max(numBins * numBins, 10000)
+ val requiredSamples = math.max(numBins * numBins, 10000.0)
--- End diff --
I'd very slightly prefer to cast this to a double in the following line.
This makes `requiredSamples` a double itself, which is slightly wrong.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
