Github user oliverpierson commented on the pull request:

    https://github.com/apache/spark/pull/11319#issuecomment-187729848
  
    Yeah, I think I can put a test together.  Also, the value `10000` in line 
113:
    
    `val requiredSamples = math.max(numBins * numBins, 10000)`
    
    is hard coded.  Should this be changed to a class attribute?  I ask because 
I test would required a dataset with dataset.count > 10000.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to