Github user nongli commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11210#discussion_r53837992
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
 ---
    @@ -521,9 +540,7 @@ case class Expand(
         AttributeSet(projections.flatten.flatMap(_.references))
     
       override def statistics: Statistics = {
    -    // TODO shouldn't we factor in the size of the projection versus the 
size of the backing child
    -    //      row?
    -    val sizeInBytes = child.statistics.sizeInBytes * projections.length
    +    val sizeInBytes = super.statistics.sizeInBytes * projections.length
    --- End diff --
    
    Is this right? This assumes each projection is the identity right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to