Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11210#discussion_r53839539
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/types/UserDefinedType.scala ---
    @@ -74,7 +74,7 @@ abstract class UserDefinedType[UserType] extends DataType 
with Serializable {
       /**
        * The default size of a value of the UserDefinedType is 4096 bytes.
        */
    -  override def defaultSize: Int = 4096
    +  override def defaultSize: Int = sqlType.defaultSize
    --- End diff --
    
    The old value is bad guess, because we always materialize the rows as 
sqlType, so should use that. Will remove the comment while merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to