Github user oliverpierson commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11319#discussion_r53852686
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
    @@ -103,6 +103,13 @@ final class QuantileDiscretizer(override val uid: 
String)
     
     @Since("1.6.0")
     object QuantileDiscretizer extends 
DefaultParamsReadable[QuantileDiscretizer] with Logging {
    +
    +  /**
    +   * Minimum number of samples required for finding splits, regardless of 
number of bins.  If
    +   * the dataset has less rows than this value, the entire dataset column 
will be used.
    +   */
    +  val minSamplesRequired: Int = 10000
    --- End diff --
    
    The test will require creating a dataset at least as large as 
`minSamplesRequired`, so making its value excessively large could slow down 
testing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to