Github user zhonghaihua commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10794#discussion_r54058368
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
 ---
    @@ -78,6 +78,9 @@ class CoarseGrainedSchedulerBackend(scheduler: 
TaskSchedulerImpl, val rpcEnv: Rp
       // Executors that have been lost, but for which we don't yet know the 
real exit reason.
       protected val executorsPendingLossReason = new HashSet[String]
     
    +  // The num of current max ExecutorId used to re-register appMaster
    +  var currentExecutorIdCounter = 0
    --- End diff --
    
    Hi @jerryshao , thanks for your comments. The master branch is different 
from branch-1.5.x version. In master branch,`CoarseGrainedSchedulerBackend` is 
belong to module `core` and `YarnSchedulerBackend` is belong to module `yarn` , 
while in branch-1.5.x version it is belong to the same package. So, from my 
understanding, `protected` is unsuited here, right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to