Github user lgieron commented on a diff in the pull request:
https://github.com/apache/spark/pull/11396#discussion_r54339929
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -992,6 +992,9 @@ case class FormatNumber(x: Expression, d: Expression)
val sb = classOf[StringBuffer].getName
val df = classOf[DecimalFormat].getName
+ val dfs = classOf[DecimalFormatSymbols].getName
+ val l = classOf[Locale].getName
+ val US = "US"
--- End diff --
(I am assuming you're referring to the `US` variable).
It would work to just have it inside the string below.
I decided to define it separately purely on grounds of taste - this way,
the String does not contain any names of classes or objects. Putting the `US`
in would be an exception, which (IMO) would make the code slighly harder to
read.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
