Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11396#discussion_r54350009
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -992,6 +992,9 @@ case class FormatNumber(x: Expression, d: Expression)
val sb = classOf[StringBuffer].getName
val df = classOf[DecimalFormat].getName
+ val dfs = classOf[DecimalFormatSymbols].getName
+ val l = classOf[Locale].getName
+ val US = "US"
--- End diff --
It's not a big deal but my tastes would run opposite. This is another layer
of indirection and the variable "US" to represent the string "US" doesn't seem
to add anything. At least I might call it "locale" or something. "l" might be
better as "localeClass"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
