Github user thomastechs commented on a diff in the pull request:
https://github.com/apache/spark/pull/10912#discussion_r54375435
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -445,4 +445,10 @@ class JDBCSuite extends SparkFunSuite with
BeforeAndAfter {
assert(agg.getCatalystType(1, "", 1, null) == Some(StringType))
}
+ test("OracleDialect type mapping") {
+ val oracleDialect = JdbcDialects.get("jdbc:oracle://127.0.0.1/db")
+ assert(oracleDialect.getJDBCType(StringType).
+ map(_.databaseTypeDefinition).get == "VARCHAR2(255)")
+ }
+
--- End diff --
This is similar to testcase written for MySQL,for branch 1.4; which is not
actually spinning up any MySQL or Oracle instance; but for the test suite
purpose, as I believe. So far, builds for this PR for branch 1.4, failed due
to style checks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
