Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10912#discussion_r54473515
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -445,4 +445,9 @@ class JDBCSuite extends SparkFunSuite with
BeforeAndAfter {
assert(agg.getCatalystType(1, "", 1, null) == Some(StringType))
}
+ test("OracleDialect type mapping") {
--- End diff --
Also, it will be good to make the test name more specific on what it will
test. I am going to change it while merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
